STI and multi attributes models in Rails

class CreateLandingForms < ActiveRecord::Migration  def change    create_table :landing_forms do |t|      t.string :type      t.jsonb :data      t.timestamps    end  endend

# app/models/landing_form.rb# == Schema Information## Table name: landing_forms##  id         :bigint           not null, primary key#  data       :jsonb#  type       :string#  created_at :datetime         not null#  updated_at :datetime         not null#class LandingForm < ApplicationRecordend

# app/models/landing_forms/christmas.rbmodule LandingForms  class Christmas < LandingForm    store_accessor :data, :full_name, :phone_number, :city, :state, :address, :gift    validates :full_name, presence: true    validates :phone_number, presence: true    validates :city, presence: true    validates :state, presence: true    validates :address, presence: true    validates :gift, presence: true    def self.permitted_params      [:full_name, :phone_number, :city, :state, :address, :gift]    end  endend

# app/models/landing_forms/black_friday.rbmodule LandingForms  class BlackFriday < LandingForm    store_accessor :data, :first_name, :last_name, :email    scope :by_email, ->(email) { where(["data->>'email' IN (?)", email]) }    validates :first_name, presence: true    validates :last_name, presence: true    validates :email, presence: true    validate :unique_email    def self.permitted_params      [:first_name, :last_name, :email]    end    private    def unique_email      return if errors.size.positive?      return if self.class.where(type: type).by_email(email).where.not(id: id).count.zero?      errors.add(:email, I18n.t('landing_forms.email_already_taken'))    end  endend

# spec/factories/landing_form_factory.rbFactoryBot.define do  # factory for one model  factory :black_friday_form, class: LandingForms::BlackFriday do    first_name { Faker::Name.first_name }    last_name { Faker::Name.last_name }    email { Faker::Internet.email }  end  # factory for another model  factory :christmas_form, class: LandingForms::Christmas do    full_name { Faker::Name.name_with_middle }    phone_number { Faker::PhoneNumber.phone_number }    city { Faker::Address.city }    state { Faker::Address.state }    address { Faker::Address.full_address }    gift { Faker::Hipster.sentence }  endend

# spec/models/landing_form_spec.rbrequire 'rails_helper'RSpec.describe LandingForms::Christmas, type: :model do  let(:item) { build(:christmas_form) }  it 'works' do    expect(item.save).to eq(true)  endendRSpec.describe LandingForms::BlackFriday, type: :model do  let(:item) { build(:black_friday_form) }  it 'works' do    expect(item.save).to eq(true)  end  describe 'unique email validation' do    let!(:item1) { create(:black_friday_form) }    context 'email is not the same' do      let(:item2) { build(:black_friday_form) }      it 'is valid' do        expect(item2.valid?).to eq(true)        expect(item2.save).to eq(true)      end    end    context 'email is the same' do      let(:item2) { build(:black_friday_form, email: item1.email) }      it 'is not valid' do        expect(item2.valid?).to eq(false)        expect(item2.errors.attribute_names).to include(:email)        expect(item2.errors[:email]).to include(I18n.t('landing_forms.email_already_taken'))      end    end  endend

Rails.application.routes.draw donamespace :api do    namespace :v1 do      namespace :landing_forms do        post :black_friday, to: 'black_friday#create'        post :christmas, to: 'christmas#create'      end    end  endend

# app/controllers/api/v1/landing_forms/black_friday_controller.rbmodule Api  module V1    module LandingForms      class BlackFridayController < ApplicationController        def create          object = model_class.new(model_params)          if object.valid? && object.save            render json: { success: true }          else            render json: object.errors, status: :unprocessable_entity          end        end        private        def model_params          params.permit(*model_class.permitted_params)        end        def model_class          ::LandingForms::BlackFriday        end      end    end  endend

# spec/requests/api/v1/landing_forms/black_friday_spec.rbrequire 'rails_helper'RSpec.describe Api::V1::SubscriptionsController, type: :request do  describe '#create' do    subject { post '/api/v1/landing_forms/black_friday', params: params, as: :json }    before { subject }    context 'email validation' do      let!(:item1) { create(:black_friday_form) }      context 'email is unique' do        let(:params) do          { first_name: Faker::Name.first_name, last_name: Faker::Name.last_name, email: Faker::Internet.email }        end        it 'renders success' do          expect(response).to have_http_status(:ok)          expect(JSON.parse(response.body)['success']).to eq(true)        end      end      context 'email is the same' do        let(:params) do          { first_name: Faker::Name.first_name, last_name: Faker::Name.last_name, email: item1.email }        end        it 'returns errors' do          expect(response).to have_http_status(:unprocessable_entity)          json = JSON.parse(response.body)          expect(json.keys).to eq(['email'])          expect(json['email']).to include(I18n.t('landing_forms.email_already_taken'))        end      end    end  endend