An Interest In:
Web News this Week
- April 24, 2024
- April 23, 2024
- April 22, 2024
- April 21, 2024
- April 20, 2024
- April 19, 2024
- April 18, 2024
Doing code reviews
This week, I had a chance to review some pull requests from different students in IPC144 repo.
Review #1
I did some reviews for this a PR on Information.md
but the author ran into some technical issues, I tried to help him to resolve using git, but he deleted his fork and tried opening new PRs. I pointed out some typo issues, markdown issues and his mistake committing an unresolved conflict. You can check them here, PR#1, PR#2, PR#3
Review #2
I pointed out an unnecessary section of the page of the PR on functions-arrays-and-structs.md
and advised an accessibility improvement on this PR
My thoughts
Reviewing does take quite some time and great attention to details especially with those PRs. I did have some fun reading people's reviews and I learnt more about correct markdown syntaxes. I hope to review more challenging PRs next time.
Original Link: https://dev.to/tuenguyen2911_67/doing-code-reviews-12op
Dev To
An online community for sharing and discovering great ideas, having debates, and making friendsMore About this Source Visit Dev To