An Interest In:
Web News this Week
- April 23, 2024
- April 22, 2024
- April 21, 2024
- April 20, 2024
- April 19, 2024
- April 18, 2024
- April 17, 2024
My first PR in hacktoberfest 2021
Hello every, my name is Dustin. I'd like to talk about my experience of solving very first and simple issues on github that are labelled as hacktoberfest 2021.
Reasons
The reason behind why I decided to contribute to open sources project is because I will learn a bunch of new things and coding styles.
First pull request
My very first pull request was pretty simple and short in terms of coding but reading the code and finding where it is to fix was difficult enough.
The project can be found here
My pull request can be found here
Detail
Interesting enough though, when I understood the issue clearly and started to fork the project, I got into a problem where I cannot clone the project locally. You can find the issue here but it turned out that there a little space after a file name. A project maintainer resolved it immediately so that I could clone the project.
The issue was actually about a url link. There's a few buttons that allow users to copy, or share the post on their social platforms. But the link was assigned to a static url that points straight to the main landing page. So what I did was that I pull the current url off of window.location.href
and set it to the URL. Every worked just fine. The process of fixing code was quite easy but I had to go through a lot of files and folders to find the issue because this project is quite huge.
const URL = 'https://seismic-risc.now.sh';
to
const URL = window.location.href;
Original Link: https://dev.to/tuanthanh2067/my-first-pr-in-hacktoberfest-2021-2dcf
Dev To
An online community for sharing and discovering great ideas, having debates, and making friendsMore About this Source Visit Dev To